Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dashes - in the tenant, environment and stage names #143

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Apr 22, 2022

what

  • Support dashes - in the tenant, environment and stage names
  • In the examples, add a new stage test-1 and add tests for components, stacks, and spacelift to test having a dash in the stage name (the file name itself being without dashes)

why

  • The old atmos supported it (because it was filename-based, not logical stack name based)
  • Some clients want to name tenants/environment/stages with dashes in the names (and some already have it, so we need to support that when converting from the old to the new atmos)

test

atmos terraform plan test/test-component-override-3 -s tenant1-ue2-test-1


Found config for the component 'test/test-component-override-3' for the stack 'tenant1-ue2-test-1' 
in the file 'tenant1/ue2/test1'

Variables for the component 'test/test-component-override-3' in the stack 'tenant1-ue2-test-1':

enabled: true
environment: ue2
namespace: eg
region: us-east-2
service_1_list:
- 5
- 6
- 7

@aknysh aknysh added the patch A minor, backward compatible change label Apr 22, 2022
@aknysh aknysh self-assigned this Apr 22, 2022
@aknysh aknysh requested review from a team as code owners April 22, 2022 22:21
@aknysh aknysh merged commit ae7272f into master Apr 22, 2022
@aknysh aknysh deleted the update-16 branch April 22, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants