generated from cloudposse/example-app-on-eks
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
44 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
### TP Card: | ||
* [TP-ID_Number](TP_URL) | ||
|
||
### Why?: | ||
* | ||
|
||
### What's Done: | ||
* | ||
|
||
### Does this PR include specs for any new or modified code? | ||
|
||
1. [ ] :white_check_mark: | ||
2. [ ] :question: Not sure? Please reach out to another developer for assistance | ||
3. [ ] :x: **REQUIRED: please provide an explanation describing why this PR is missing specs** | ||
- Explanation: | ||
|
||
### Are there any security considerations for this PR? | ||
|
||
1. [ ] :white_check_mark: | ||
2. [ ] :x: | ||
- Please elaborate as needed: | ||
|
||
### Does this PR ensure? | ||
|
||
- [ ] No business logic in view (.erb files) | ||
- [ ] Object level assumption is verified (e.g. handle null object appropriately) | ||
* Note - Dev to confirm the above during PR creation. | ||
|
||
### Was the code you're committing subject to a design review? | ||
|
||
- [ ] Yes | ||
- [ ] No, but I'm **certain** the change is isolated and will not negatively impact other features or performance generally | ||
- [ ] No, and I'm not sure what impact my change will have on other features and performance generally | ||
|
||
|
||
### Browser Tested: | ||
|
||
- [ ] Chrome | ||
- [ ] Others | ||
- [ ] N/A | ||
|
||
### Screenshot or GIF: | ||
|
||
**Mandatory** — You need to attach a screenshot/screen-cast if you made any changes to the UI |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters