Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ecs-web-app module and support using private repository #38

Merged
merged 9 commits into from
Apr 22, 2021

Conversation

maeghan-porter
Copy link
Contributor

what

  • Upgrade the ecs-web-app module version to the latest and support the usage of private repositories by allowing the user to pass in private repository credentials for ecs to use.

why

  • Private image repositories are an option to use and so this module should provider the ability to use them by allowing setting of the credentials on the task definition.

@maeghan-porter maeghan-porter requested review from a team as code owners April 22, 2021 21:59
@mergify
Copy link

mergify bot commented Apr 22, 2021

This pull request is now in conflict. Could you fix it @maeghan-porter? 🙏

jamengual
jamengual previously approved these changes Apr 22, 2021
@jamengual
Copy link
Contributor

/test all

@mergify mergify bot dismissed jamengual’s stale review April 22, 2021 22:06

This Pull Request has been updated, so we're dismissing all reviews.

@jamengual jamengual merged commit 706790e into cloudposse-archives:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants