Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin GitHub provider to 3.0.0 #30

Merged
merged 9 commits into from
Feb 5, 2021
Merged

Pin GitHub provider to 3.0.0 #30

merged 9 commits into from
Feb 5, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 5, 2021

what

  • Restore TF 0.12 support
  • Remove github_anonymous
  • Use modules pinned to GitHub provider 3.0.0

why

  • Update/fix TF 0.12 compatible module before dropping support for TF 0.12
  • GitHub provider dropped support for github_anonymous
  • GitHub provider has breaking changes with every release, 3.0.0 seemed the best balance of stable, bug-free, and compatible with our codebase

@Nuru Nuru requested review from a team as code owners February 5, 2021 05:24
@Nuru Nuru requested review from jamengual and RothAndrew and removed request for a team February 5, 2021 05:24
@Nuru Nuru changed the title Pin provider Pin GitHub provider to 3.0.0 Feb 5, 2021
@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test all

osterman
osterman previously approved these changes Feb 5, 2021
View reviewed changes
@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test all

@Nuru Nuru requested a review from osterman February 5, 2021 06:07
@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test terratest

@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Feb 5, 2021

/test all

@Nuru Nuru requested a review from johncblandii February 5, 2021 22:57
@Nuru Nuru merged commit 53fccec into master Feb 5, 2021
@Nuru Nuru deleted the pin-provider branch February 5, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

@johncblandii johncblandii Awaiting requested review from johncblandii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @osterman @cloudpossebot