Updating modules dependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknysh
previously approved these changes
Jul 3, 2020
|
/test all |
osterman
previously approved these changes
Jul 3, 2020
|
/test all |
|
/rebuild-readme |
|
/test all |
…terraform-aws-ecs-atlantis into updating_module_dependencies
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test terratest |
|
/test all |
|
/test all |
|
/test all |
osterman
reviewed
Jul 3, 2020
test/Makefile
Outdated
| @@ -4,6 +4,9 @@ TEST_HARNESS_PATH = $(realpath .test-harness) | |||
| BATS_ARGS ?= --tap | |||
| BATS_LOG ?= test.log | |||
|
|
|||
| # Expose GitHub Token as github_webhooks_token variable so that SSM does not fail | |||
| export TF_VAR_github_webhooks_token ?= $(GITHUB_TOKEN) | |||
There was a problem hiding this comment.
Oh, this is the wrong Makefile. Move it to test/src/Makefile
There was a problem hiding this comment.
(this is the Makefile for the bats automated testing. The tests are failing with terratest)
The bats is currently failing due to listing. run terraform fmt for that.
|
Update the PR description to explain why the renaming of the variables. |
|
/terraform-fmt |
|
/rebuild-readme |
|
/test all |
…terraform-aws-ecs-atlantis into updating_module_dependencies
|
/test all |
|
/test all |
|
/test terratest |
|
/test all |
osterman
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why