Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Recursive clone support #5

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/events/working_dir.go
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@ func (w *FileWorkspace) forceClone(log *logging.SimpleLogger,
if w.TestingOverrideCloneURL != "" {
cloneURL = w.TestingOverrideCloneURL
}
cloneCmd := exec.Command("git", "clone", cloneURL, cloneDir) // #nosec
cloneCmd := exec.Command("git", "clone", "--recurse-submodules", cloneURL, cloneDir) // #nosec
if output, err := cloneCmd.CombinedOutput(); err != nil {
return "", errors.Wrapf(err, "cloning %s: %s", headRepo.SanitizedCloneURL, string(output))
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment by the maintainer of Atlantis. He said it needs to support both arg formats based on git version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.