This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Fix git submodules #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Oct 23, 2018
| if err := checkoutCmd.Run(); err != nil { | ||
| return "", errors.Wrapf(err, "checking out branch %s", p.Branch) | ||
| // Recursively update submodules for the branch | ||
| log.Info("updating submodules for branch %q", p.Branch) |
There was a problem hiding this comment.
Will this work if:
a) no submodules defined
b) without calling git submoule init first?
There was a problem hiding this comment.
a) tested on a repo w/o submodules, the command just returns w/o any errors
b) merged into one command git submodule update --init --recursive, tested on repos with and without submodules
osterman
approved these changes
Oct 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why