Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Add git clone --recurse-submodules #11

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Conversation

aknysh
Copy link

@aknysh aknysh commented Oct 16, 2018

what

  • Add git clone --recurse-submodules

why

test

=== RUN   TestCreateGitCloneCommand
Found Git version: 2.17.1
git clone arguments: [git clone --recurse-submodules https://github.com/runatlantis/atlantis /tmp/runatlantis/atlantis]
--- PASS: TestCreateGitCloneCommand (0.02s)

@aknysh aknysh self-assigned this Oct 16, 2018
@aknysh aknysh requested a review from osterman October 16, 2018 19:21
@osterman osterman mentioned this pull request Oct 16, 2018
@aknysh aknysh merged commit a22bda2 into master Oct 16, 2018
@aknysh aknysh deleted the add-git-recursive-clone branch October 16, 2018 19:35
@aknysh aknysh mentioned this pull request Oct 16, 2018
@sdwerwed
Copy link

sdwerwed commented Mar 16, 2021

@aknysh the submodule is empty, this doesn't clone the module for other branches, you need to explicitly specify -b <branch_name>, otherwise the module will be empty once do checkout. You can replicate by creating a new branch and add the submodule, then do PR to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants