Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install development version of dask in downstream tests #472

Merged
merged 2 commits into from
May 20, 2022
Merged

Install development version of dask in downstream tests #472

merged 2 commits into from
May 20, 2022

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented May 20, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #472 (a6643c0) into master (f926a04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files           4        4           
  Lines         717      717           
  Branches      158      158           
=======================================
  Hits          664      664           
  Misses         32       32           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f926a04...a6643c0. Read the comment docs.

@jrbourbeau
Copy link
Member Author

@jakirkham @ogrisel could one of you add the ci distributed label when you get a chance?

@ogrisel ogrisel added the ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle) label May 20, 2022
@ogrisel
Copy link
Contributor

ogrisel commented May 20, 2022

Done. I can add you as a committer on this project if you wish.

@jrbourbeau
Copy link
Member Author

That'd be great : )

ogrisel
ogrisel approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this fixes some failures, +1 on my side.

@jakirkham
Copy link
Member

jakirkham commented May 20, 2022 •
edited
Loading

This fixes nearly all failures, but test_stack_overflow is failing on CI with a RecursionError

@ogrisel
Copy link
Contributor

ogrisel commented May 20, 2022

Let's merge this as this is already a net improvement.

@ogrisel ogrisel merged commit 0006829 into cloudpipe:master May 20, 2022
@jakirkham
Copy link
Member

Sounds good. Filed issue ( dask/distributed#6406 ) to track that failure.

@jrbourbeau jrbourbeau deleted the dask-main branch May 20, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
ci distributed Signal the CI to run the test suite of distributed (downstream project of cloudpickle)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudpickle's downstream distributed tests failing
3 participants
@jrbourbeau @ogrisel @jakirkham