Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save bound classmethod py27 #289

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

pierreglaser
Copy link
Member

Fixes #288.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #289 into master will increase coverage by 26.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #289       +/-   ##
===========================================
+ Coverage   66.66%   92.78%   +26.12%     
===========================================
  Files           2        2               
  Lines         846      846               
  Branches      177      177               
===========================================
+ Hits          564      785      +221     
+ Misses        259       37      -222     
- Partials       23       24        +1
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 91.96% <100%> (+1.28%) ⬆️
cloudpickle/cloudpickle_fast.py 95.08% <0%> (+95.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc4374...779a45e. Read the comment docs.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is simple. Let's merge but let's wait a bit prior to releasing 1.2.2.

@ogrisel ogrisel merged commit d884a01 into cloudpipe:master Jun 12, 2019
@pierreglaser pierreglaser deleted the save-bound-classmethod-py27 branch June 12, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudpickle cannot save bound classmethods for python2.7
2 participants