Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX More func base globals fixes #198

Merged
merged 18 commits into from
Sep 13, 2018

Commits on Sep 11, 2018

  1. Configuration menu
    Copy the full SHA
    f56958c View commit details
    Browse the repository at this point in the history
  2. FIX added checking into sys.modules before trying to import base_globals

    during unpickling, in order to recreate the previous environnement an object lived in,
    the module under the base_globals name is re-imported. However, it
    is not always possible, especially if base_globals pointed to a
    temporary or locally defined module. This PR introduces a fix that
    checks if the module still exists during unpickling
    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    d6a040d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c8e536 View commit details
    Browse the repository at this point in the history
  4. added base_globals caching and fixed python 2 crash

    two main fixes here:
    * added a _BASE_GLOBALS_CACHE, that will track a functions globals in the
    environnement where it is loaded
    
    * fixed a python 2 issue due to dynamic_subimport
    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    8626c8d View commit details
    Browse the repository at this point in the history
  5. pep8

    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    afcf8d7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2031c60 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ec045b3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    26bc794 View commit details
    Browse the repository at this point in the history
  9. dynamic modules test now ran in a separate process

    this modification was done to prevent side effects, and affectation
    of cloudpickle's global variable, (here, _dynamic_modules).
    Now, those global variables are only changed in ephemere child
    processes
    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    8d672a6 View commit details
    Browse the repository at this point in the history
  10. typos

    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    cbbb1e1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    71dc5a3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5dc9f14 View commit details
    Browse the repository at this point in the history
  13. reverted dynamic modules behavior

    dynamic modules globals are not stored in a dict.
    Each time a function from a dynamic module gets unpickled,
    a new set of globals is created
    pierreglaser committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    9535636 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    da966e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. removed test_function_from_dynamic_module...

    also updated CHANGES.md
    pierreglaser committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8980610 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eddb2f8 View commit details
    Browse the repository at this point in the history
  3. formatting

    pierreglaser committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    8c290b7 View commit details
    Browse the repository at this point in the history
  4. final formatting reworks

    pierreglaser committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    7bc6a82 View commit details
    Browse the repository at this point in the history