FIX globals for functions defined in __main__ #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 84.09% 84.68% +0.58%
==========================================
Files 1 1
Lines 547 555 +8
Branches 99 104 +5
==========================================
+ Hits 460 470 +10
+ Misses 63 62 -1
+ Partials 24 23 -1
Continue to review full report at Codecov.
|
This was referenced Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #187
The cause of this issue is that global variables defined in
__main__are not shared by unpickled functions and their value are overwritten at each unpickling.