Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI #308

Merged
merged 2 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ jobs:
# Machine environment:
# https://help.github.com/en/articles/software-in-virtual-environments-for-github-actions#ubuntu-1804-lts
# We specify the Node.js version manually below, and use versioned Chrome from Puppeteer.
runs-on: ubuntu-20.10
runs-on: ubuntu-20.04

steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.9.0
uses: actions/setup-node@v4
- uses: actions/setup-node@v4
with:
node-version: 20.9.0
node-version: 20.x
- name: Install dependencies
run: yarn --frozen-lockfile --non-interactive --no-progress
- name: Lint Demo
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ npm i ngx-sub-form
**Note about the versions:**

| `@angular` version | `ngx-sub-form` version |
|----------------------|------------------------------------------------------|
| -------------------- | ---------------------------------------------------- |
| v <= `7` | v <= `2.7.1` |
| `8.x` | `4.x` |
| `9.x` <= v <= `12.x` | `5.1.2` |
Expand Down
8 changes: 4 additions & 4 deletions cypress/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/**
* Cypress 12 has an issue in combination with typescript 5.0.x
* "Option 'sourceMap' cannot be specified with option 'inlineSourceMap'"
* https://github.com/cypress-io/cypress/issues/26203
**/
* Cypress 12 has an issue in combination with typescript 5.0.x
* "Option 'sourceMap' cannot be specified with option 'inlineSourceMap'"
* https://github.com/cypress-io/cypress/issues/26203
**/
{
"extends": "../tsconfig",
"compilerOptions": {
Expand Down