Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IfaceHasNoAddr check for external ip delete error #971

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

qingkunl
Copy link
Contributor

@qingkunl qingkunl commented Aug 14, 2020

When creating externlIP service with DSR tunnel, I got the following error log, and kube-router failed to create the related IPVS tunnel.

0813 23:38:37.465953 1642001 network_services_controller.go:1762] Successfully added service: TCP::80 (Flags: )
E0813 23:38:37.469536 1642001 service_endpoints_sync.go:313] Failed to delete external ip adress from dummyVipInterface due to cannot assign requested address

This is because when the externalIP service is created for the first time, the externalIP didn't exist on the dummy interface before, the nsc.ln.ipAddrDel call above my change would result in IfaceHasNoAddr error, preventing routeVIPTrafficToDirector function below to create the IPVS tunnel. Therefore, the IfaceHasNoAddr error should be ignored.

@aauren aauren added the bug label Aug 14, 2020
@murali-reddy
Copy link
Member

murali-reddy commented Aug 14, 2020

LGTM thanks @qingkunl

@murali-reddy murali-reddy merged commit 7613a73 into cloudnativelabs:master Aug 14, 2020
@aauren aauren mentioned this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants