-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the advertise-service-cluster-ip-range parameter to summarize the announcement function of the service network segment, reduce the routing entries of the connected network devices, and support a larger BGP network. #920
Closed
cloudnativer
wants to merge
36
commits into
cloudnativelabs:master
from
cloudnativer:advertise-cluster-subnet
Closed
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
352fa95
Add the advertise-cluster-subnet parameter to summarize the announcem…
c5a5977
modify img file
368dee1
Update large-networks03.md
cloudnativer 7b5c657
Update large-networks03.md
cloudnativer a478274
Update large-networks03.md
cloudnativer 534ef18
Update large-networks03.md
cloudnativer f4e127d
Update large-networks02.md
cloudnativer 6765295
Update large-networks01.md
cloudnativer 1a7d578
Update large-networks01.md
cloudnativer 6a2d846
changed advertise-cluster-subnet to advertise-service-cluster-ip-range
15dedb4
Update large-networks01.md
cloudnativer b1e7cfa
Update large-networks03.md
cloudnativer c168e2f
Change advertise-cluster-subnet in the document to advertise-service-…
cloudnativer 59220e7
Change advertise-cluster-subnet in the document to advertise-service-…
cloudnativer 5f71bf5
Update large-networks02.md
cloudnativer f5f3789
Update large-networks02.md
cloudnativer 8e31460
Update large-networks02.md
cloudnativer 71f280f
Update large-networks03.md
cloudnativer 0eb2243
Update large-networks03.md
cloudnativer 908b760
Update large-networks03.md
cloudnativer 5831fa7
Update large-networks03.md
cloudnativer 9977b99
Update large-networks02.md
cloudnativer ecf8865
Update large-networks04.md
cloudnativer 35aa65c
Update large-networks04.md
cloudnativer d83b15b
Update large-networks01.md
cloudnativer 281dd47
Update large-networks01.md
cloudnativer 47a5eaa
Update large-networks01.md
cloudnativer 5d28d52
Update large-networks01.md
cloudnativer 0bc2ed4
Update kube-router-daemonset-advertise-cluster-subnet.yaml
cloudnativer 7d42a10
Update large-networks03.md
cloudnativer 963a94b
Update large-networks03.md
cloudnativer 3ef1b0d
Update large-networks03.md
cloudnativer 6d0513f
Update large-networks03.md
cloudnativer 42b3788
Separate code changes from documentation, leaving only code changes.
invalid-email-address 67c6acf
Cut down the length of the description to a single line, and Add long…
invalid-email-address 0bc222e
See large-networks03 documentation for details
cloudnativer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like both service CIDR and service VIP to be announced only for the services marked with external traffic policy set to local. So that on upstream routers which has
/32
route to a VIP is given precedence over route to service cluster IP range.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloudnativer Did you give any thought to above comment? I see below three scenarios
--advertise-service-cluster-ip-range
is configured then advertise ONLY the service cluster IP range from the nodes and DO NOT advertise service VIP's from the node (which is what this PR intends to achieve) irrespective of fact service has pod's running on the node and service is markedexternalTrafficPolicy=Local
.--advertise-service-cluster-ip-range
is configured then advertise the service cluster IP range from the nodes AND advertise/32
service VIP's from the node if node has a endpoint pod corresponding to the service running on the node and service is markedexternalTrafficPolicy=Local
.--advertise-service-cluster-ip-range
is NOT configured then keep the original behaviour i.e.) advertise/32
VIP from all the nodes if service is not marked withexternalTrafficPolicy=Local
and advertise service VIP ONLY from the nodes which has a endpoint pod corresponding to the service is running on the node and service is marked withexternalTrafficPolicy=Local
problem with #1 is it can blackhole the traffic for services set to
externalTrafficPolicy=Local
. Traffic to service VIP get's ECMP ed to a node not running any service endpoint pod and proxy running on the node will reject the traffic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem does exist if
externalTrafficPolicy=Local
is set.(1) The applicable conditions of
advertise-service-cluster-ip-range
are as follows:externalTrafficPolicy
can only be used when the service is set to loadbalancer or nodeport.externalTrafficPolicy=Cluster
at the same time, so that theadvertise-service-cluster-ip-range
parameter is meaningful.advertise-service-cluster-ip-range
.(2) In large-scale environment, network traffic load balancing is very important. However, the configuration of
externalTrafficPolicy=Local
will lead to unbalanced network traffic load, so our production environment uses the defaultexternalTrafficPolicy=Cluster
.