fix(network_routes): missing node ip -> error log #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @aauren I think use of checked all the references for |
aauren
force-pushed
the
fix_missing_node_ip
branch
from
d966fdd
to
7092cf2
Compare
|
@murali-reddy Good catch! I added the instance of |
|
Sorry. My bad. I should have been more clear (references outside bgp_peers.go are all clean). There are 2 more such usages left in |
aauren
force-pushed
the
fix_missing_node_ip
branch
from
7092cf2
to
5a3308d
Compare
Before we used to raise an error when a node was missing an IP, but it turns out that this is not a required attribute of a node. And while it is rare that a node would be missing an IP address, a node doesn't require an IP address or a name or really much of anything in order to exist. This brings us to stronger conformance with the Kubernetes API and makes it so that kube-router logs errors rather than changing it's health status and potentially causing cascading failures across the fleet if a user adds a node like this.
aauren
force-pushed
the
fix_missing_node_ip
branch
from
5a3308d
to
d001b7a
Compare
|
@murali-reddy I fixed the remaining references in bgp_peers. Take another look when you have time. |
|
Thanks LGTM |
mrueg
pushed a commit
to mrueg/kube-router
that referenced
this pull request
May 31, 2020
Before we used to raise an error when a node was missing an IP, but it turns out that this is not a required attribute of a node. And while it is rare that a node would be missing an IP address, a node doesn't require an IP address or a name or really much of anything in order to exist. This brings us to stronger conformance with the Kubernetes API and makes it so that kube-router logs errors rather than changing it's health status and potentially causing cascading failures across the fleet if a user adds a node like this.
FabienZouaoui
pushed a commit
to SirDataFR/kube-router
that referenced
this pull request
Jun 22, 2020
Before we used to raise an error when a node was missing an IP, but it turns out that this is not a required attribute of a node. And while it is rare that a node would be missing an IP address, a node doesn't require an IP address or a name or really much of anything in order to exist. This brings us to stronger conformance with the Kubernetes API and makes it so that kube-router logs errors rather than changing it's health status and potentially causing cascading failures across the fleet if a user adds a node like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@murali-reddy This goes towards fixing another rare, but outstanding bug with kube-router for the 1.0.0 release.
Before we used to raise an error when a node was missing an IP, but it turns out that this is not a required attribute of a node. And while it is rare that a node would be missing an IP address, a node doesn't require an IP address or a name or really much of anything in order to
exist.
This brings us to stronger conformance with the Kubernetes API and makes it so that kube-router logs errors rather than changing it's health status and potentially causing cascading failures across the fleet if a user adds a node like this.
Properly fixes #846