nflog the packet that will be dropped by network policy enforcement #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that can be further by read by ulogd Fixes #505
Closed
mrueg
reviewed
Apr 26, 2020
| @@ -817,6 +817,14 @@ func (npc *NetworkPolicyController) syncPodFirewallChains(version string) (map[s | |||
| } | |||
| } | |||
|
|
|||
| // add rule to log the packets that will be droopped due to network policy enforcement | |||
| comment = "rule to log dropped traffic POD name:" + pod.name + " namespace: " + pod.namespace | |||
There was a problem hiding this comment.
Suggested change
| comment = "rule to log dropped traffic POD name:" + pod.name + " namespace: " + pod.namespace | |
| comment = "rule to log dropped traffic to POD name:" + pod.name + " namespace: " + pod.namespace |
There was a problem hiding this comment.
@mrueg thanks for the review. I started with same but actually a only a single IPtable rule gets created so unfortunaltye can not add to/from. Resolved other comment
| @@ -933,6 +941,14 @@ func (npc *NetworkPolicyController) syncPodFirewallChains(version string) (map[s | |||
| } | |||
| } | |||
|
|
|||
| // add rule to log the packets that will be droopped due to network policy enforcement | |||
| comment = "rule to log dropped traffic POD name:" + pod.name + " namespace: " + pod.namespace | |||
There was a problem hiding this comment.
Suggested change
| comment = "rule to log dropped traffic POD name:" + pod.name + " namespace: " + pod.namespace | |
| comment = "rule to log dropped traffic from POD name:" + pod.name + " namespace: " + pod.namespace |
mrueg
reviewed
Apr 26, 2020
aauren
approved these changes
Apr 28, 2020
@aauren Thank for the review. I will add an e.g in usage guide on how to enable loggiging. For more convenience we can log in kube-router logs as well by doing like this |
aauren
approved these changes
May 1, 2020
mrueg
pushed a commit
to mrueg/kube-router
that referenced
this pull request
May 10, 2020
…loudnativelabs#889) * nflog the packet that will be dropped by network policy enforcement that can be further by read by ulogd Fixes cloudnativelabs#505 * addressing review comments
FabienZouaoui
pushed a commit
to SirDataFR/kube-router
that referenced
this pull request
May 11, 2020
…loudnativelabs#889) * nflog the packet that will be dropped by network policy enforcement that can be further by read by ulogd Fixes cloudnativelabs#505 * addressing review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logged packets can be further by read by ulogd
Fix only works with kernel > 4.11 please see #505 (comment)
Fixes #505