Issue 572 - Graceful termination + Update to go-1.10.8, alpine-3.9 #706
Conversation
roffe
changed the title
|
Not sure if it will help to run the |
roffe
changed the title
|
@mrueg i've spent the whole day trying to get the tests working on 1.11 but it seems the routing controller ones are the ones failing, specificly it seems it's related to gobgp somehow deadlocking in the tests. |
|
Closes #572 |
| @@ -3,7 +3,7 @@ services: | |||
|
|
|||
| language: go | |||
| go: | |||
| - 1.10.x | |||
| - 1.10.8 | |||
There was a problem hiding this comment.
1.10.x is technically 1.10.8, not sure if this is needed
There was a problem hiding this comment.
would suggest to add a comment that tests are stuck with 1.11.x and later here instead
There was a problem hiding this comment.
The tests for the router controller does not work with Go 1.11, i suspect it being due to the old vendored goBGP server
| @@ -1059,9 +1100,9 @@ func (nsc *NetworkServicesController) syncIpvsServices(serviceInfoMap serviceInf | |||
| // cleanup stale IPs on dummy interface | |||
| glog.V(1).Info("Cleaning up if any, old service IPs on dummy interface") | |||
| addrActive := make(map[string]bool) | |||
| for k, endpoints := range activeServiceEndpointMap { | |||
| for k := range activeServiceEndpointMap { | |||
There was a problem hiding this comment.
@murali-reddy The problem I had is that services that does not have any endpoints are flapping, making many unnecessary LN calls to add and remove the service on every sync. also if the only endpoint in the service is gracefully terminating we can't yank the service out under it.
| } | ||
| } | ||
| } | ||
|
|
||
| func (nsc *NetworkServicesController) sync() error { | ||
| func (nsc *NetworkServicesController) sync(syncType int) { |
There was a problem hiding this comment.
The new behaviour is instead of having a blocking sync() on every update we have a overflowing channel, if there is a request to sync while we are syncing we will do it in the next run() loop. we won't have X-XX amount of them hanging in the air due to the mutex
|
thanks @roffe LGTM |
Add graceful termination for IPVS destinations
Cleanup main loop of Network Service Controller
Stop removing services with 0 endpoints
Upgrade vendored libnetwork & netlink library ( to get statistics for IPVS destinations )
Update to go-1.10.8 & alpine 3.9