Introduces the option --overlay-type={subnet,full}, to be able to always generate IPIP tunnels regardless of node subnets #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Feb 24, 2019
docs/user-guide.md
Outdated
| --enable-pod-egress SNAT traffic from Pods to destinations outside the cluster. (default true) | ||
| --enable-pprof Enables pprof for debugging performance and memory leak issues. | ||
| --full-overlay When full-overlay is set to true, it changes "--enable-overlay=true" default behavior so that IP-in-IP tunneling is used for pod-to-pod networking across nodes regardless of the subnet the nodes are in. When set to false, the default, default "--enable-overlay=true" behavior is used |
There was a problem hiding this comment.
What do you think about using --overlay-type instead, with a default value regional or subnet. And the other option is type?
There was a problem hiding this comment.
Sounds like a good idea to me. I don't know if I understood your question correctly ("And the other option is type?"). Could you elaborate a bit more?
There was a problem hiding this comment.
Sorry, typo. I meant "And the other option is full".
So user needs to set both
--enable-overlay=true
--overlay-type={subnet,full}
There was a problem hiding this comment.
Sorry, typo. I meant "And the other option is full".
Now I got it :)
So user needs to set both
--enable-overlay=true --overlay-type={subnet,full}
Yes, it makes sense. I've updated the code to reflect that.
lucasmundim
force-pushed
the
full_overlay
branch
from
2ed3613
to
d9a6367
Compare
lucasmundim
changed the title
|
Did basic testing switching flag |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements PR #371 ideas, keeping the existing behaviour but allowing users to opt in for a full overlay regardless of the subnet the nodes are in