Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep ipset names consistent #613

Closed
wants to merge 1 commit into from
Closed

keep ipset names consistent #613

wants to merge 1 commit into from

Conversation

murali-reddy
Copy link
Member

renaming KUBE-SVC-ALL to kube-router-svc-all to keep it consistent with other kube-router ipset's (kube-router-pod-subnets, kube-router-node-ips)

CC: @bazuchan

@roffe
Copy link
Collaborator

roffe commented Dec 17, 2018 •
edited
Loading

won't this leave a old ipset on the node after upgrading kube-router

@murali-reddy
Copy link
Member Author

Its unreleased change (#604) so its fine.

@asteven
Copy link
Contributor

asteven commented Dec 20, 2018 •
edited
Loading

FWIW I'm almost done with a PR to fully address #282 which also renames the above mentioned ipset for consistency.

I went with "kube-router-ipvs-services" for the ip:port ipset.
And "kube-router-service-ips" for the 'ip' ipset.

@asteven asteven mentioned this pull request Dec 20, 2018
Merged
@murali-reddy
Copy link
Member Author

closing in favour of #618

@aauren aauren deleted the kube-router-svc-all branch September 4, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murali-reddy @roffe @asteven