Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change package name from v1core to corev1 #1281

Closed
wants to merge 1 commit into from

Conversation

lucming
Copy link

@lucming lucming commented Apr 15, 2022

No description provided.

@lucming
Copy link
Author

lucming commented Apr 18, 2022

k8s.io/api/core/v1 this package we often use the alias as corev1 instead of v1core,it's better to rename it.

@aauren
Copy link
Collaborator

aauren commented Apr 19, 2022

I'm not opposed to renaming it, but I'm also not in favor of changing it just because. Can you give more information about the benefit of this change? Specifically what projects benefit from this changing and why this effort is worthwhile?

@lucming
Copy link
Author

lucming commented Apr 20, 2022

I'm not opposed to renaming it, but I'm also not in favor of changing it just because. Can you give more information about the benefit of this change? Specifically what projects benefit from this changing and why this effort is worthwhile?

It's just a matter of naming conventions, we can often see ${group}${version} in the code from k8s instead of ${version}${group}. It might be more standardized in this way.

@aauren
Copy link
Collaborator

aauren commented May 27, 2022

Currently waiting on the work in #1280 and and #1224 to go in first. Those PRs were raised first and would require a lot of rebasing after incorporating this PR.

@lucming
Copy link
Author

lucming commented May 31, 2022

Currently waiting on the work in #1280 and and #1224 to go in first. Those PRs were raised first and would require a lot of rebasing after incorporating this PR.

ok,i will push this pr,you can tell me after those pr merged

@aauren
Copy link
Collaborator

aauren commented Apr 24, 2023

@lucming sorry that I came back around to this so late.

A lot happened with that work that I previously linked. If you're still interested in updating this, I'm still open to accepting it, but it would need to be targeted at the prep-v2.0 branch which is where we're staging the active work that we're doing.

@aauren aauren closed this Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants