Fix for same issue as #750, but for network_routes_controller

cloudnativelabs · Apr 26, 2020 · 86ebd28 · 86ebd28
1 parent 21ea5a5
commit 86ebd28
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/pkg/controllers/routing/network_routes_controller.go b/pkg/controllers/routing/network_routes_controller.go
@@ -467,11 +467,7 @@ func (nrc *NetworkRoutingController) injectRoute(path *table.Path) error {
 		}
 
 		out, err := exec.Command("ip", "route", "list", "table", customRouteTableID).CombinedOutput()
-		if err != nil {
-			return fmt.Errorf("Failed to verify if route already exists in %s table: %s",
-				customRouteTableName, err.Error())
-		}
-		if !strings.Contains(string(out), "dev "+tunnelName+" scope") {
+		if err != nil || !strings.Contains(string(out), "dev "+tunnelName+" scope") {
 			if out, err = exec.Command("ip", "route", "add", nexthop.String(), "dev", tunnelName, "table",
 				customRouteTableID).CombinedOutput(); err != nil {
 				return fmt.Errorf("failed to add route in custom route table, err: %s, output: %s", err, string(out))