Tweak open() and sys_open() to return EFAULT error when pathname null

Signed-off-by: Waldemar Kozaczuk <[email protected]>
cloudius-systems · May 16, 2019 · a0dcf85 · a0dcf85
1 parent 9cb7e73
commit a0dcf85
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/fs/vfs/main.cc b/fs/vfs/main.cc
@@ -120,6 +120,11 @@ int open(const char *pathname, int flags, ...)
     int fd, error;
     int acc;
 
+    if (pathname == nullptr) {
+        error = EFAULT;
+        goto out_errno;
+    }
+
     acc = 0;
     switch (flags & O_ACCMODE) {
     case O_RDONLY:

diff --git a/fs/vfs/vfs_syscalls.cc b/fs/vfs/vfs_syscalls.cc
@@ -117,6 +117,10 @@ sys_open(char *path, int flags, mode_t mode, struct file **fpp)
 	DPRINTF(VFSDB_SYSCALL, ("sys_open: path=%s flags=%x mode=%x\n",
 				path, flags, mode));
 
+	if (path == nullptr) {
+		return (EFAULT);
+	}
+
 	flags = fflags(flags);
 	if (flags & O_CREAT) {
 		error = namei(path, &dp);