This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix: update-api-to-match-wdio #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixZilber
requested review from
refael-m and
AlexeyCL
and removed request for
refael-m
refael-m
reviewed
Sep 13, 2021
| */ | ||
| export function executeScript(script: string): string { | ||
| export function execute(script: string): string { |
There was a problem hiding this comment.
you should add optional arguments parameter
There was a problem hiding this comment.
since we are passing the full script everywhere, and for the sake of simplicity, I left it without arguments
AlexeyCL
reviewed
Sep 19, 2021
AlexeyCL
reviewed
Sep 19, 2021
AlexeyCL
reviewed
Sep 19, 2021
| * it can be single key or an array of keys | ||
| * @param keysToSend key, array of keys or string array (chars) to send | ||
| */ | ||
| export function sendKeys(keysToSend: SpecialKeys | Array<SpecialKeys> | string | Array<string>): void { | ||
| export function keys(keysToSend: SpecialKeys | Array<SpecialKeys> | string | Array<string>): void { |
There was a problem hiding this comment.
Send a sequence of key strokes to the active element. You can also use characters like "Left arrow" or "Back space". WebdriverIO will take care of translating them into unicode characters. You’ll find all supported characters here. To do that, the value has to correspond to a key from the table.
There was a problem hiding this comment.
what's your point here?
There was a problem hiding this comment.
that you can remove keysToSend: SpecialKeys | Array
|
@FelixZilber well done!! |
refael-m
approved these changes
Sep 22, 2021
AlexeyCL
approved these changes
Sep 22, 2021
BREAKING CHANGE: update BrowserUtils API to match the wdio api
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.