This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Apps 9798 add publish job #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh-job # Conflicts: # .github/workflows/publish-package.yml
…APPS-9798-add-publish-job # Conflicts: # .github/workflows/publish-package.yml
…APPS-9798-add-publish-job # Conflicts: # CHANGELOG.md
FelixZilber
reviewed
Jul 7, 2021
| @@ -40,5 +34,36 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
line 15, better to use actions/checkout@v2 as well
FelixZilber
reviewed
Jul 7, 2021
| run: | | ||
| git config user.name ${{ secrets.USERNAME }} | ||
| git config user.email "${{ secrets.MAIL }}" | ||
| yarn release |
There was a problem hiding this comment.
need a better name for this phase. it's not releasing a package at this point
FelixZilber
reviewed
Jul 7, 2021
| yarn release | ||
|
|
||
| - name: push changes | ||
| run: git push --follow-tags origin HEAD |
There was a problem hiding this comment.
use master instead of HEAD
FelixZilber
reviewed
Jul 7, 2021
| token: ${{ secrets.NPM_TOKEN }} | ||
|
|
||
| slack_notification: | ||
| needs: [ release_package ] |
There was a problem hiding this comment.
this will be executed only in case of success. need to send a message also in case of failure
FelixZilber
approved these changes
Jul 7, 2021
refael-m
approved these changes
Jul 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.