Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python client verisons update: #208

Merged

Conversation

kbijakowski
Copy link
Contributor

python-novaclient from 7.0.0 to 10.1.0
python-keystoneclient from 3.5.0 to 3.15.0
python-neutronclient from 6.0.0 to 6.7.0
python-cinderclient from 1.9.0 to 3.5.0
python-glanceclient from 2.5.0 to 2.9.1

  • support for nova_net reources remove (no longer supported by python clients)
  • keypair create - set runtime properites fix
  • server create - handling images using glance_client instead of nova_client (support for listing images in nova_client has been removed)
  • cloudify.openstack.server_connected_to_floating_ip - new implementation (server.remove_floating_ip and server.add_floating_ip method removed from nova_client)
  • removing floatingIP from port - detaching port using neutron_client instaed on nova_client (server.remove_floating_ip method removed from nova_client)

Also blueprints used for testing added

Tested on Cloudify Labs (cfy mgr v.4.2)

python-novaclient from 7.0.0 to 10.1.0
python-keystoneclient from 3.5.0 to 3.15.0
python-neutronclient from 6.0.0 to 6.7.0
python-cinderclient from 1.9.0 to 3.5.0
python-glanceclient from 2.5.0 to 2.9.1

- support for nova_net reources remove (no longer supported by python clients)
- keypair create - set runtime properites fix
- server create - handling images using glance_client instead of nova_client (support for listing images in nova_client has been removed)
- cloudify.openstack.server_connected_to_floating_ip - new implementation (server.remove_floating_ip and server.add_floating_ip method removed from nova_client)
- removing floatingIP from port - detaching port using neutron_client instaed on nova_client (server.remove_floating_ip method removed from nova_client)

Also blueprints used for testing added
Copy link

@mabuaisha mabuaisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let some comments

name: 'openstack_plugin_test_user'
use_external_resource: false
resource_id: 'openstack_plugin_test_user'
openstack_config:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbijakowski I think we can use dsl_definitions here

dsl_definitions:
   openstack_config: &openstack_config
      username: { get_input: openstack_username }
      password: { get_input: openstack_password }
      tenant_name: { get_input: openstack_project_name }
      auth_url: { get_input: openstack_auth_url }
      region: { get_input: openstack_region }

and then use it below in all nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE (only for places where admin tenant config is used)


openstack_project_id:
type: string
default: 'b5a748ef817c4333b48380a239374472'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbijakowski We we do not use secret pair here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE. I added getting keystone_tenant_id here. Only one problem here is that (if I am not wrong) tenant_id isn't natively added to Cloudify Manager secret store during installation (bootstrap). It (tenant_id) is required for neutron resources because of this: #205.

server_group: { get_attribute: [ server_groups, server_group_list] }
keystone:
users: { get_attribute: [ users, user_list] }
projects: { get_attribute: [ projects, project_list] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbijakowski Add new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

def process_rules(client, sgr_default_values, cidr_field_name,
remote_group_field_name, min_port_field_name,
max_port_field_name):
rules_to_apply = ctx.node.properties['rules']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbijakowski What if the properties does not contain a rules key what happen on this case ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@mabuaisha
Copy link

@kbijakowski good to go

@EarthmanT EarthmanT changed the base branch from master to 3.0.0-dev March 5, 2018 12:06
@EarthmanT EarthmanT merged commit 12d9fbd into cloudify-cosmo:3.0.0-dev Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants