Correctly set Content-Length when using Ruby 1.9 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man! Nice! I was too lazy to get into deep of the problem :)) Thanks for solving it (will merge your patch into mine branch) Woo-hoo! :)) |
cloudhead
pushed a commit
that referenced
this pull request
Mar 19, 2012
Correctly set Content-Length when using Ruby 1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meaning of String#length changed between 1.8 and 1.9. This commit clarifies that Content-Length is the number of bytes, and monkey-patches String#bytesize into 1.8.
I think the default setup for Heroku is now Ruby 1.9, so it makes sense to ensure that Toto works with it.
See #91, #86, etc.