Friendly display of article having a damaged "front matter" #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not damaged means : YAML parses string and returns a Hash)
dunno ...
|
That's a great proposal I think. The only I would like to see is more obvious method names and error messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
Having a damaged file under /articles prevents site from displaying '/'
Damaged?
By damaged, I mean front matter does not parse to Hash using YAML.load
(I had a quick search on ticket 'convert' keyword, and did not find)
So here is a topic branch for this functionality
Why do I think it is useful ?
One mistake means no site
I made a demo with such an article ... (git checkout saved me after 30s of bewilderment)
What may be better ?
reduce list of article to undamaged articles (ignore damaged article)
Cheers