Update suitcss-utils-size dependency
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 And I believe that 2.0 update to the size utils was due to an issue filed by @saralohr a while back. |
erikjung
approved these changes
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of working in @nicolemors' work for v2 of the notifications UI, I found that we needed to be running the latest version,
2.0.0, of thesuitcss-utils-sizedependency. I was having a challenge applying theu-hiddenclass so I dug deeper. As it turns out, they removed thedisplayproperty fromu-sizeFullin2.0.0which resolves the problem I was running into.In version
1.0.2, theu-hiddenstyles would be overridden by theu-sizeFullstyles, which was causing issues.cc: @nicolemors @erikjung @tylersticka