Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and expanded feature images #1430

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

tylersticka
Copy link
Member

@tylersticka tylersticka commented Jul 21, 2021

Overview

This PR makes a number of updates to our fallback feature images:

  • Image sizes are now consistent with other article images and are integers. This is important for promoting consistent alignment and avoiding odd rendering artifacts across browsers.
  • The images themselves have been streamlined in Illustrator to avoid the use of clipping masks and to minimize decimal point strokes.
  • Rounding errors have been correct. Previously, there were some curves that had been damaged by exporting from and importing into various vector editing applications with varying pixel rounding. In those cases I recreated the shapes, sometimes making one or two improvements (IMO, anyway) along the way.
  • In addition to the four images created previously, I've added blank and cloudfour as potential fallbacks. These will be used by the theme when an appropriate image cannot be found.
  • PNG assets are included. This will make OpenGraph defaults easier to configure in the future if we decide to implement that in our theme.
  • I've updated the paths to remove "fallback," since that feels less descriptive of the what of the images and more descriptive of the why.
  • I updated the story definition to be dynamic so we can more easily expand these in the future. I also removed Canvas elements from this page because the code samples felt irrelevant, it feels more like a design reference to me.

Screenshots

Screenshot 2021-07-21 at 16-47-57 Storybook

Testing

Deploy preview


/CC @AriannaChau

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2021

🦋 Changeset detected

Latest commit: 0aba263

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,5 @@
---
'@cloudfour/patterns': minor
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a changed file path for an asset a breaking change? I guess so, but since we weren't using it yet, and since it wasn't a code change, I chose minor. Second-guessing that now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way 👍

@tylersticka tylersticka marked this pull request as ready for review July 22, 2021 00:02
@tylersticka tylersticka requested review from a team July 22, 2021 00:02
Copy link
Member

@Paul-Hebert Paul-Hebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are looking great! I left one question about alt text inline.

Out of curiosity, when would you want to use the blank version over the Cloud Four version? Is that meant to be a starting point for creating new designs? Or is it meant to be used directly on the Wordpress site?

{% block content %}
{% for image in images %}
<figure>
<img src="{{image.src}}" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include alt text for these images? We'll want to when we use them on the Wordpress site. Should the pattern library define and expose those alt descriptions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see we're just pulling the name from the filename. I was imagining there was a JSON file somewhere of data. Hmm, what do you think? Is there a good place to define those alt descriptions in the patterns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WordPress site will have a lot more information about the article the image is supposed to represent, so I'm not sure that specifying alt text here will be very useful. I think it may actually complicate implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that works for me 👍

@tylersticka
Copy link
Member Author

Out of curiosity, when would you want to use the blank version over the Cloud Four version? Is that meant to be a starting point for creating new designs? Or is it meant to be used directly on the Wordpress site?

It might be either! To be honest, I'm still figuring it out on the WordPress side of things. But it seemed potentially useful.

@tylersticka tylersticka merged commit 8216267 into v-next Jul 22, 2021
@tylersticka tylersticka deleted the feature/update-feature-fallbacks branch July 22, 2021 16:27
@github-actions github-actions bot mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants