Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Input component code examples & simplify stories #1419

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Jul 20, 2021

Overview

This PR refines the Input component code examples and simplifies a couple of the stories as well.

Screenshots

Screen Shot 2021-07-20 at 12 06 37 PM

Screen Shot 2021-07-20 at 12 07 03 PM

Testing

Preview: https://deploy-preview-1419--cloudfour-patterns.netlify.app/?path=/docs/components-input--elastic-textarea

  1. Review the Input component story code examples for accuracy

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2021

⚠️ No Changeset found

Latest commit: bdea13e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gerardo-rodriguez gerardo-rodriguez self-assigned this Jul 20, 2021
@gerardo-rodriguez gerardo-rodriguez changed the title Chore/refine input stories Refine Input component code examples & simplify stories Jul 20, 2021
@gerardo-rodriguez gerardo-rodriguez requested a review from a team July 20, 2021 19:17
@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review July 20, 2021 19:18
@gerardo-rodriguez gerardo-rodriguez requested a review from a team July 20, 2021 19:18
@@ -70,30 +88,33 @@ If the `rows` attribute is set, it will be used as the minimum height.
<Canvas>
<Story
name="Elastic Textarea"
height="350px"
height="250px"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this property necessary? (I ask because I notice it was removed from another example, probably because this component predates are inline helper that allowed us to set stories to inline by default.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question, @tylersticka!

My thought process was that, for the elastic textarea, it seemed more helpful to keep it so that you could more easily see the elastic functionality in action.

But, I'm open to opposing arguments. 😉

@gerardo-rodriguez gerardo-rodriguez merged commit 1168aca into v-next Jul 20, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the chore/refine-input-stories branch July 20, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants