-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component/input group #1405
Component/input group #1405
Conversation
🦋 Changeset detectedLatest commit: 569d272 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Tyler Sticka <[email protected]>
Co-authored-by: Tyler Sticka <[email protected]>
Co-authored-by: Tyler Sticka <[email protected]>
…cloudfour.com-patterns into component/input-group
@@ -68,6 +68,7 @@ | |||
transform transition.$quick ease.$out; | |||
user-select: none; | |||
vertical-align: middle; | |||
white-space: nowrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Gerardo Rodriguez <[email protected]>
@gerardo-rodriguez I think this is related to this PR omitting the |
Oh, that's a great point, @tylersticka! 😮 |
@gerardo-rodriguez @tylersticka Is that something that I need to fix? I can't see where I'm using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Highlighting the lines where only
is missing.
Co-authored-by: Tyler Sticka <[email protected]>
Co-authored-by: Tyler Sticka <[email protected]>
Oh you said omitting sorry I missed that part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work, @AriannaChau! 🎉
I'll defer the final approval to @tylersticka since he provided the original feedback. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some suggestions for improving the docs a little
Co-authored-by: Tyler Sticka <[email protected]>
Co-authored-by: Tyler Sticka <[email protected]>
Co-authored-by: Tyler Sticka <[email protected]>
Overview
This PR adds a new Input Group Component.
A small edit to the Button component styles adds
white-space: nowrap
so the text doesn't wrap within them.Screenshots
Testing