Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component/input group #1405

Merged
merged 21 commits into from
Jul 19, 2021
Merged

Component/input group #1405

merged 21 commits into from
Jul 19, 2021

Conversation

AriannaChau
Copy link
Contributor

@AriannaChau AriannaChau commented Jul 16, 2021

Overview

This PR adds a new Input Group Component.
A small edit to the Button component styles adds white-space: nowrap so the text doesn't wrap within them.

Screenshots

Screen Shot 2021-07-16 at 12 12 26 PM

Testing

  1. Deploy link.

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2021

🦋 Changeset detected

Latest commit: 569d272

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AriannaChau AriannaChau marked this pull request as ready for review July 16, 2021 19:32
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we prevent the borders from doubling up where the controls meet?

Screen Shot 2021-07-16 at 12 56 34 PM

@AriannaChau AriannaChau requested a review from tylersticka July 16, 2021 21:25
src/components/input-group/demo/input-group-demo.twig Outdated Show resolved Hide resolved
src/components/input-group/demo/styles.scss Outdated Show resolved Hide resolved
src/components/input-group/input-group.scss Outdated Show resolved Hide resolved
src/components/input-group/input-group.scss Outdated Show resolved Hide resolved
src/components/input-group/input-group.scss Outdated Show resolved Hide resolved
src/components/input-group/input-group.scss Outdated Show resolved Hide resolved
src/components/input-group/input-group.stories.mdx Outdated Show resolved Hide resolved
src/components/input-group/input-group.stories.mdx Outdated Show resolved Hide resolved
@@ -68,6 +68,7 @@
transform transition.$quick ease.$out;
user-select: none;
vertical-align: middle;
white-space: nowrap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AriannaChau AriannaChau requested a review from tylersticka July 19, 2021 16:50
@gerardo-rodriguez
Copy link
Member

Unrelated to this PR (as far as I can tell) but something funny is happening with the Button component. It's rendering as a <div>! 😱

We might need to create a new GH issue to figure this out. 🤔

Screen Shot 2021-07-19 at 9 52 35 AM

@tylersticka
Copy link
Member

Unrelated to this PR (as far as I can tell) but something funny is happening with the Button component. It's rendering as a <div>! 😱

@gerardo-rodriguez I think this is related to this PR omitting the only keyword after the button include path. I think it's inheriting the tag_name of the rhythm object, which defaults to div.

@gerardo-rodriguez
Copy link
Member

Unrelated to this PR (as far as I can tell) but something funny is happening with the Button component. It's rendering as a <div>! 😱

@gerardo-rodriguez I think this is related to this PR omitting the only keyword after the button include path. I think it's inheriting the tag_name of the rhythm object, which defaults to div.

Oh, that's a great point, @tylersticka! 😮

@AriannaChau
Copy link
Contributor Author

@gerardo-rodriguez @tylersticka Is that something that I need to fix? I can't see where I'm using the only keyword after the button include, unless it's implied with this line: {% include '@cloudfour/components/button/button.twig' %}

Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting the lines where only is missing.

src/objects/input-group/demo/input-group-demo.twig Outdated Show resolved Hide resolved
src/objects/input-group/demo/input-group-demo.twig Outdated Show resolved Hide resolved
@AriannaChau
Copy link
Contributor Author

Highlighting the lines where only is missing.

Oh you said omitting sorry I missed that part.

Copy link
Member

@gerardo-rodriguez gerardo-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work, @AriannaChau! 🎉

I'll defer the final approval to @tylersticka since he provided the original feedback. 😉

@AriannaChau AriannaChau requested a review from tylersticka July 19, 2021 17:28
Copy link
Member

@tylersticka tylersticka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some suggestions for improving the docs a little

src/objects/input-group/input-group.stories.mdx Outdated Show resolved Hide resolved
src/objects/input-group/input-group.stories.mdx Outdated Show resolved Hide resolved
@AriannaChau AriannaChau merged commit 2c7fb4a into v-next Jul 19, 2021
@AriannaChau AriannaChau deleted the component/input-group branch July 19, 2021 18:27
@github-actions github-actions bot mentioned this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input group pattern
4 participants