Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure button content is centered #1398

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

gerardo-rodriguez
Copy link
Member

@gerardo-rodriguez gerardo-rodriguez commented Jul 14, 2021

Overview

This PR resolves a bug where the Button component content was not centered when the button width was larger than it's default width.

Screenshots

Before

before

After

after

Testing

  1. Confirm the Button content is horizontally centered on the Comment Form component (before / after)
  2. Confirm no regressions on the Button component (before / after)

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2021

🦋 Changeset detected

Latest commit: 973b6ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudfour/patterns Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gerardo-rodriguez gerardo-rodriguez self-assigned this Jul 14, 2021
@gerardo-rodriguez gerardo-rodriguez marked this pull request as ready for review July 14, 2021 22:08
@gerardo-rodriguez gerardo-rodriguez requested review from tylersticka and a team July 14, 2021 22:13
@gerardo-rodriguez gerardo-rodriguez merged commit 85e7ed0 into v-next Jul 14, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the bug/center-button-text branch July 14, 2021 22:26
@github-actions github-actions bot mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Button component should center text
2 participants