Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.46 #3098

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.42.

Changelog

Sourced from com.nimbusds:nimbus-jose-jwt's changelog.

9.41.2 (2024-10-01) * JWEHeader must support the special case of an "aud" header value of type string (iss #569).

9.42 (2024-10-28) * Promotes getCompatibleAlgorithms from MACSigner to MACProvider. * Promotes getMinRequiredSecretLength from MACSigner to MACProvider. * Removes the Set argument from the protected MACProvider constructors, the compatible HSxxx algorithms are now determined within the constructor. * MACVerifier must enforce a minimum secret key length of 384 bits for HS384 and of 512 bits for HS512 (iss #563). * OctetSequenceKeyGenerator must support "exp", "nbf" and "iat" (iss #575). * Updates to com.google.crypto.tink:tink:1.15.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.41.2 to 9.42.
- [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt)
- [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/tag/9.42)

---
updated-dependencies:
- dependency-name: com.nimbusds:nimbus-jose-jwt
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 28, 2024
@strehle strehle added the DO NOT MERGE Internal Test or WIP, please DO NOT MERGE label Oct 29, 2024
@strehle
Copy link
Member

strehle commented Oct 29, 2024

Prevents Green Tests -> HS256 no longer allowed ,

Changelog
Sourced from com.nimbusds:nimbus-jose-jwt's changelog.

9.41.2 (2024-10-01) * JWEHeader must support the special case of an "aud" header value of type string (iss #569).

9.42 (2024-10-28) * Promotes getCompatibleAlgorithms from MACSigner to MACProvider. * Promotes getMinRequiredSecretLength from MACSigner to MACProvider. * Removes the Set argument from the protected MACProvider constructors, the compatible HSxxx algorithms are now determined within the constructor. * MACVerifier must enforce a minimum secret key length of 384 bits for HS384 and of 512 bits for HS512 (iss #563). * OctetSequenceKeyGenerator must support "exp", "nbf" and "iat" (iss #575). * Updates to com.google.crypto.tink:tink:1.15.0

Commits

- fix validation_succeeds_with_different_alg, which is failing after
bumping to com.nimbusds-nimbus-jose-jwt-9.42, which adds validation
on key length when using key algorithm HS256, see:
  - https://bitbucket.org/connect2id/nimbus-jose-jwt/src/60b715f220c1eaf0bdd8c28488d52b0851160ec7/CHANGELOG.txt#lines-1704
  - https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/563/incorrect-validation-of-secret-length-for
@peterhaochen47
Copy link
Member

peterhaochen47 commented Oct 30, 2024

Yeah, looks like the test can be fixed (see commit) but would this be a breaking change? Given that we currently don't put validation on the user-provided key length in the bosh release (haven't checked the API but probably we don't either).

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2024

A newer version of com.nimbusds:nimbus-jose-jwt exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@strehle
Copy link
Member

strehle commented Nov 1, 2024

Yeah, looks like the test can be fixed (see commit) but would this be a breaking change? Given that we currently don't put validation on the user-provided key length in the bosh release (haven't checked the API but probably we don't either).

Yes removing HS256 is a breaking change but we should announce it and then do it in next major version

I dont know prod. customer with HSxxx usage, but only RS256

…com.nimbusds-nimbus-jose-jwt-9.42

# Conflicts:
#	dependencies.gradle
@strehle strehle removed the DO NOT MERGE Internal Test or WIP, please DO NOT MERGE label Nov 13, 2024
@strehle strehle changed the title build(deps): bump com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.42 build(deps): bump com.nimbusds:nimbus-jose-jwt from 9.41.2 to 9.46 Nov 13, 2024
@strehle strehle merged commit 4fda5b5 into develop Nov 13, 2024
22 checks passed
@strehle strehle deleted the dependabot/gradle/com.nimbusds-nimbus-jose-jwt-9.42 branch November 13, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants