-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump opensaml2 from 2.6.6 to 4.0.1 #2908
base: develop
Are you sure you want to change the base?
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187710947 The labels on this github issue will be updated when the story is started. |
...ava/org/cloudfoundry/identity/uaa/provider/saml/SamlLegacyAliasResponseForwardingFilter.java
Fixed
Show fixed
Hide fixed
65b0d64
to
e67a40a
Compare
a761b67
to
7de27a1
Compare
0d3a595
to
f199f50
Compare
46248b9
to
290f89c
Compare
46248b9
to
b6cb65b
Compare
a97457f
to
745fff3
Compare
.../cloudfoundry/identity/uaa/provider/saml/ConfiguratorRelyingPartyRegistrationRepository.java
Outdated
Show resolved
Hide resolved
.../cloudfoundry/identity/uaa/provider/saml/ConfiguratorRelyingPartyRegistrationRepository.java
Outdated
Show resolved
Hide resolved
...ava/org/cloudfoundry/identity/uaa/provider/saml/Saml2BearerGrantAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ava/org/cloudfoundry/identity/uaa/provider/saml/Saml2BearerGrantAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
...ava/org/cloudfoundry/identity/uaa/provider/saml/Saml2BearerGrantAuthenticationConverter.java
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/provider/saml/Saml2Utils.java
Show resolved
Hide resolved
SAML2 bearer and IdP initated flows are similar and the IdP initiated flow still is not working. The resolver needs to be forked / implemented on Uaa side, I assume then we can resolve from issuer to idP . SAML2 bearer works now independent from amount of SAML2 trusts, #3132 |
* Test saml bearer * Fixes for SAML2 bearer flow * reverted test
# Conflicts: # dependencies.gradle
* Test saml bearer * Fixes for SAML2 bearer flow * reverted test * Implement RelyingPartyRegistrationResolver * support resolution of SAMLResponse from request * remove default setting * Use standard setting of metadata the feature with classpath is new in this PR. * refactorings based on sonar * Replace dummy-saml-idp-metadata and create the data based on real key data Until now we do not deliver any keys in uaa.war. * Cleanup test failure Changed, because of hack with defaults. * Rename DefaultRelyingPartyRegistrationResolver to UaaRelyingPartyRegistrationResolver Signed-off-by: Duane May <[email protected]> * Refactor text blocks Signed-off-by: Duane May <[email protected]> --------- Signed-off-by: Duane May <[email protected]> Co-authored-by: Duane May <[email protected]> Co-authored-by: Duane May <[email protected]>
# Conflicts: # dependencies.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a long time LGTM
- thanks to broadcom
- manually tested SAML flows
Bumps commons-io:commons-io from 2.17.0 to 2.18.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Modified `cargo.local` to run with jacoco agent if a system property is set. - Added a task to generate coverage report from the recorded jacoco data.
Replacing the other feature branch #2862 for new SAML library replacement effort.
Sonar
https://sonarcloud.io/summary/new_code?id=cloudfoundry-identity-parent&pullRequest=2908