-
Notifications
You must be signed in to change notification settings - Fork 827
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sonar refactoring - AbstractUaaEvent class (#2891)
Remove duplicates Added test class
- Loading branch information
Showing
3 changed files
with
200 additions
and
89 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
156 changes: 156 additions & 0 deletions
156
server/src/test/java/org/cloudfoundry/identity/uaa/audit/event/AbstractUaaEventTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| package org.cloudfoundry.identity.uaa.audit.event; | ||
|
|
||
| import org.cloudfoundry.identity.uaa.annotations.WithDatabaseContext; | ||
| import org.cloudfoundry.identity.uaa.audit.AuditEventType; | ||
| import org.cloudfoundry.identity.uaa.audit.JdbcAuditService; | ||
| import org.cloudfoundry.identity.uaa.audit.UaaAuditService; | ||
| import org.cloudfoundry.identity.uaa.oauth.UaaOauth2Authentication; | ||
| import org.cloudfoundry.identity.uaa.oauth.provider.OAuth2Authentication; | ||
| import org.cloudfoundry.identity.uaa.oauth.provider.OAuth2Request; | ||
| import org.cloudfoundry.identity.uaa.oauth.provider.authentication.OAuth2AuthenticationDetails; | ||
| import org.cloudfoundry.identity.uaa.scim.event.GroupModifiedEvent; | ||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.jdbc.core.JdbcTemplate; | ||
| import org.springframework.security.core.Authentication; | ||
| import org.springframework.security.core.context.SecurityContextHolder; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.hamcrest.CoreMatchers.not; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
| import static org.hamcrest.Matchers.containsString; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertNull; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| @WithDatabaseContext | ||
| class AbstractUaaEventTest { | ||
|
|
||
| @Autowired | ||
| private JdbcTemplate jdbcTemplate; | ||
|
|
||
| AbstractUaaEvent event; | ||
| UaaAuditService auditListener; | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| event = GroupModifiedEvent.groupCreated("group", "groupName", new String[0], "uaa"); | ||
| auditListener = new JdbcAuditService(jdbcTemplate); | ||
| } | ||
|
|
||
| @AfterEach | ||
| void cleanUp() { | ||
| SecurityContextHolder.clearContext(); | ||
| } | ||
|
|
||
| @Test | ||
| void process() { | ||
| event.process(auditListener); | ||
| assertNotNull(auditListener); | ||
| } | ||
|
|
||
| @Test | ||
| void createAuditRecord() { | ||
| assertNotNull(event.createAuditRecord("me", AuditEventType.GroupModifiedEvent, "notuaa")); | ||
| } | ||
|
|
||
| @Test | ||
| void getAuthentication() { | ||
| assertNotNull(event.getAuthentication()); | ||
| } | ||
|
|
||
| @Test | ||
| void getContextAuthentication() { | ||
| Authentication authentication = AbstractUaaEvent.getContextAuthentication(); | ||
| assertNotNull(authentication); | ||
| SecurityContextHolder.getContext().setAuthentication(authentication); | ||
| String originString = event.getOrigin(authentication); | ||
| assertThat(originString, is("caller=null")); | ||
| } | ||
|
|
||
| @Test | ||
| void getOrigin() { | ||
| UaaOauth2Authentication authentication = mock(UaaOauth2Authentication.class); | ||
| OAuth2Request oAuth2Request = mock(OAuth2Request.class); | ||
| when(authentication.getOAuth2Request()).thenReturn(oAuth2Request); | ||
| when(authentication.getName()).thenReturn("marissa"); | ||
| when(authentication.getDetails()).thenReturn(Map.of("misc", "somedetails", "remoteAddress", "external")); | ||
| SecurityContextHolder.getContext().setAuthentication(authentication); | ||
| String originString = event.getOrigin(authentication); | ||
| assertThat(originString, containsString("marissa")); | ||
| assertThat(originString, containsString("client=null")); | ||
| assertThat(originString, containsString("misc=somedetails")); | ||
| assertThat(originString, containsString("remoteAddress=external")); | ||
| assertThat(originString, containsString("details=({")); | ||
| } | ||
|
|
||
| @Test | ||
| void getOriginNotAuthenticated() { | ||
| assertNull(event.getOrigin(null)); | ||
| } | ||
|
|
||
| @Test | ||
| void getOriginDetailsParsed() { | ||
| UaaOauth2Authentication authentication = mock(UaaOauth2Authentication.class); | ||
| OAuth2Request oAuth2Request = mock(OAuth2Request.class); | ||
| when(authentication.getOAuth2Request()).thenReturn(oAuth2Request); | ||
| when(authentication.getName()).thenReturn("marissa"); | ||
| when(authentication.getDetails()).thenReturn("{\"misc\":\"somedetails\",\"remoteAddress\":\"external\"}"); | ||
| SecurityContextHolder.getContext().setAuthentication(authentication); | ||
| String originString = event.getOrigin(authentication); | ||
| assertThat(originString, containsString("marissa")); | ||
| assertThat(originString, containsString("client=null")); | ||
| assertThat(originString, not(containsString("misc=somedetails"))); | ||
| assertThat(originString, containsString("remoteAddress=external")); | ||
| assertThat(originString, not(containsString("{"))); | ||
| } | ||
|
|
||
| @Test | ||
| void getAuthenticationJsonWebTokenValue() { | ||
| String originTokenString = event.getOrigin(mockAuthenticationWithToken("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiJtYXJpc3NhIiwiaXNzIjoidWFhIn0.omitted")); | ||
| assertThat(originTokenString, containsString("client=clientid")); | ||
| assertThat(originTokenString, containsString("iss=uaa")); | ||
| assertThat(originTokenString, containsString("sub=marissa")); | ||
| } | ||
|
|
||
| @Test | ||
| void getAuthenticationOpaqueTokenValue() { | ||
| String originTokenString = event.getOrigin(mockAuthenticationWithToken("any-value")); | ||
| assertThat(originTokenString, containsString("client=clientid")); | ||
| assertThat(originTokenString, containsString("opaque-token=present")); | ||
| assertThat(originTokenString, not(containsString("any-value"))); | ||
| } | ||
|
|
||
|
|
||
| @Test | ||
| void getAuthenticationTokenValueInvalid() { | ||
| String originTokenString = event.getOrigin(mockAuthenticationWithToken("fake.token.value")); | ||
| assertThat(originTokenString, containsString("client=clientid")); | ||
| assertThat(originTokenString, containsString("<token extraction failed>")); | ||
| assertThat(originTokenString, not(containsString("fake"))); | ||
| assertThat(originTokenString, not(containsString("value"))); | ||
| } | ||
|
|
||
| private Authentication mockAuthenticationWithToken(String token) { | ||
| OAuth2Authentication authentication = mock(OAuth2Authentication.class); | ||
| OAuth2Request oAuth2Request = mock(OAuth2Request.class); | ||
| when(authentication.getOAuth2Request()).thenReturn(oAuth2Request); | ||
| OAuth2AuthenticationDetails auth2AuthenticationDetails = mock(OAuth2AuthenticationDetails.class); | ||
| when(authentication.getDetails()).thenReturn(auth2AuthenticationDetails); | ||
| when(authentication.isClientOnly()).thenReturn(true); | ||
| when(auth2AuthenticationDetails.getTokenValue()).thenReturn(token); | ||
| when(oAuth2Request.getClientId()).thenReturn("clientid"); | ||
| return authentication; | ||
| } | ||
|
|
||
| @Test | ||
| void getIdentityZoneId() { | ||
| assertEquals("uaa", event.getIdentityZoneId()); | ||
| } | ||
| } |