Some additions to the Dynatrace extension #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added unit tests for manifest.json handling Added tests for setting default logstream added setting default logstream. added download retry with exponential backoff added unit tests for setting DT_LOGSTREAM sanitized installDir path setting added agentBuilderLibPath var to get rid of multiple calls to filepath.Join improved log messages for setting env vars a bit added test for download retry expanded test for 404 message
|
Hey arthfl! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/153813557 The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Added a bunch of things to the Dynatrace extension:
detection if there is more than one credential service, if yes: fail, since that is not supported.
download retry: failed installer downloads retry 3 times with exponential backoff. This should help prevent issues with mass deployments and download throttling.
skiperrors flag: gives the user/customer the option to ignore errors from the installer download. It will then just skip the rest of the steps after the download and the overall app deployment doesn't fail. This is a request we had from various customers to prevent failing app deployments in case of small network hickups or throttling issues.
the path to the agent binary is now taken from the manifest.json file instead of being hardcoded into the extension. This makes it failsafer and future changes in filepaths do not require changes to the buildpack-extension anymore.
default for environment variable DT_LOGSTREAM added. If the user/customer doesn't set the variable, we set it to 'stdout'.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test