Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing backslashes in prometheus_ctl #348

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

Infra-Red
Copy link
Contributor

After the upgrade to v26.0.0 I noticed that web.external-url flag shows empty string in Prometheus Command-Line Flags page. In my environment all command line flags after the storage.tsdb.no-lockfile flag are not initialized during the start.
This also affects Alertmanager integration with Prometheus.

@Infra-Red
Copy link
Contributor Author

@frodenas Could you please review this PR?
I would also mark v26.0.0 as a pre-release.

@frodenas frodenas merged commit a2b84f9 into cloudfoundry:master Oct 30, 2019
@frodenas
Copy link
Contributor

Thanks @Infra-Red

@Infra-Red Infra-Red deleted the feature/fix-prom-ctl branch November 26, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants