Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for boshrelease #23

Merged
merged 12 commits into from
May 3, 2023
Merged

Fixes for boshrelease #23

merged 12 commits into from
May 3, 2023

Conversation

a18e
Copy link
Contributor

@a18e a18e commented Apr 27, 2023 •
edited
Loading

boshrelease:

  • allow pcap-api to run w/o TLS to platform (TLS currently not working)
    -- add spec tests for non-TLS mode
    -- adjust example manifest/ops files to run w/o platform TLS
  • add pcap-agent to pcap-api manifest so it get's deployed on the pcap-api VMs as well
  • update dependencies: stemmcell, releases
  • mTLS between api & agents currently works using a workaround: pcap-agents reuse whole cert-chain (instead of just CA) from pcap-api
  • minimal supported TLS version is now 1.2

pcap-api Go code:

  • fix bug with decoding certificate files with newlines
  • add unit tests for certificate file parsing

@a18e a18e added the run-ci Triggers PR Validation label May 2, 2023
@a18e a18e marked this pull request as ready for review May 2, 2023 16:15
@a18e a18e requested a review from a team as a code owner May 2, 2023 16:15
maxmoehl
maxmoehl requested changes May 3, 2023
View reviewed changes
jobs/pcap-api/templates/pcap-api.yml.erb Outdated Show resolved Hide resolved
b1tamara
b1tamara reviewed May 3, 2023
View reviewed changes
manifests/pcap-api.yml Outdated Show resolved Hide resolved
b1tamara
b1tamara reviewed May 3, 2023
View reviewed changes
manifests/pcap-api.yml Outdated Show resolved Hide resolved
b1tamara
b1tamara reviewed May 3, 2023
View reviewed changes
manifests/pcap-api.yml Outdated Show resolved Hide resolved
b1tamara
b1tamara reviewed May 3, 2023
View reviewed changes
manifests/pcap-api.yml Outdated Show resolved Hide resolved
@a18e a18e requested a review from maxmoehl May 3, 2023 14:27
@a18e a18e merged commit 6770bdb into cloudfoundry:main May 3, 2023
@a18e a18e deleted the adapt-bosh branch May 3, 2023 15:05
@CFN-CI
Copy link
Contributor

CFN-CI commented May 12, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@a18e a18e mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1tamara b1tamara b1tamara left review comments

@maxmoehl maxmoehl maxmoehl approved these changes

Assignees
No one assigned
Labels
released run-ci Triggers PR Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a18e @CFN-CI @b1tamara @maxmoehl