Implement bosh integration #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoshCapture -> BoshQuery CloudfoundryCapture -> CloudfoundryQuery Capture -> AgentEndpoints
(Works with current implementation of pcap-api)
AgentEndpoints -> EndpointRequest
- client.go not yet used - update config.example.yml to current yaml config
- Working bosh_agent_resolver tests - mock-bosh-api reuses mock jwt and bosh api - Refactoring: EndpointQueryHandler -> AgentResolver (interface & BoshAgentResolver)
- minor optimizations to mock-bosh-api
- minor optimizations to mock-bosh-api
- use zap for logging in client - fixes for protobuf refactor/rename - integration_test: SetupBoshAgentResolver (currently non-functional (only supports one port)
- forward captureinfo fields timestamp and length from agent to client - fix logging in client
- bosh_agent_resolver.go: make setup private, include in constructor, adjust tests
- TLS configuration for pcap-bosh-cli against BoshDirectorAPI & pcap-api - refactor client - [WIP] unit tests for client - minor type change in pcap.proto - pb type fix for pcap-api-cli
(functions now public)
- move bosh-environment logic to bosh.go - clean up bosh-cli/main.go
- comments in bosh-cli/main.go - adjust tests to new Environment handling - linter fixes
BoshResolver, CfResolver
peanball
reviewed
Mar 14, 2023
peanball
reviewed
Mar 16, 2023
peanball
reviewed
Mar 16, 2023
- integration test for client
maxmoehl
reviewed
Apr 13, 2023
The setup() function is called explicitly in `NewBoshResolver()`.
Add per-call location list of signals and make clear that this function is generic.
Co-authored-by: Maximilian Möhl <[email protected]>
There is a deferred exit handler already. Reuse that one but don't log the error (again) via logger if it's a flags parsing error. The flags package already prints out the error to stdout.
peanball
force-pushed
the
implement-bosh-integration
branch
from
9013b80
to
fb03161
Compare
Also correct some error handling aronud JSON parsing.
peanball
force-pushed
the
implement-bosh-integration
branch
from
440a797
to
3051ee7
Compare
We don't need a loop as we stop on any of the selected signals.
maxmoehl
approved these changes
Apr 14, 2023
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.