Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: New tasks should adopt the configured cfProcessDefaults #1197

Closed
gcapizzi opened this issue Jun 7, 2022 · 0 comments
Closed

[Feature]: New tasks should adopt the configured cfProcessDefaults #1197

gcapizzi opened this issue Jun 7, 2022 · 0 comments
Assignees
@danail-branekov @georgethebeatle
Labels
Tasks
Milestone
v0.2

Comments

@gcapizzi
Copy link
Contributor

gcapizzi commented Jun 7, 2022 •
edited
Loading

Background

As a developer
I want to run tasks
So that I can execute one-off workloads

Acceptance Criteria

  • WHEN I create a task via the Kubernetes API
    THEN I I see the task pod has resource limits and requests matching the cfProcessDefaults in our configuration:

    • spec.containers[].resources.limits.memory and spec.containers[].resources.requests.memory should match cfProcessDefaults.memoryMB
    • spec.containers[].resources.limits.ephemeral-storage and spec.containers[].resources.requests.ephemeral-storage should match cfProcessDefaults.diskMB

    AND I see the following fields in the task status:

    • memoryMB matching cfProcessDefaults.memoryMB
    • diskQuotaMB matching cfProcessDefaults.diskMB

  • WHEN I create a task via the Korifi API shim
    THEN I I see all of the above
    AND I see the following fields in the response:

    • memory_in_mb matching cfProcessDefaults.memoryMB
    • disk_in_mb matching cfProcessDefaults.diskMB

Dev Notes
@gcapizzi gcapizzi added the Tasks label Jun 7, 2022
@gcapizzi gcapizzi mentioned this issue Jun 7, 2022
Closed
georgethebeatle added a commit that referenced this issue Jun 14, 2022
@gcapizzi @georgethebeatle
Apply default memory and disk to Tasks
75af1a0 
Issue: #1197
Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle added a commit that referenced this issue Jun 14, 2022
@gcapizzi @georgethebeatle
Apply default memory and disk to Tasks
1e85e1d 
Issue: #1197
Co-authored-by: Georgi Sabev <[email protected]>
@georgethebeatle georgethebeatle mentioned this issue Jun 14, 2022
Merged
georgethebeatle added a commit that referenced this issue Jun 15, 2022
@gcapizzi @georgethebeatle
Apply default memory and disk to Tasks
03a2182 
Issue: #1197
Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov added a commit to cloudfoundry/eirini-controller that referenced this issue Jun 15, 2022
@danail-branekov @georgethebeatle
Set resource limits/requests on tasks' jobs
74fa3e7 
Issue: cloudfoundry/korifi#1197

Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov added a commit that referenced this issue Jun 15, 2022
@danail-branekov @georgethebeatle
Bump eirini to 0.4.0
10a219c 
This version propagates the disk/memory constraints to the pod template
of the cf task job as limits/requests

Issue: #1197

Co-authored-by: Georgi Sabev <[email protected]>
@danail-branekov danail-branekov mentioned this issue Jun 15, 2022
Merged
danail-branekov added a commit that referenced this issue Jun 15, 2022
@danail-branekov @georgethebeatle
Bump eirini to 0.4.0
c202a82 
This version propagates the disk/memory constraints to the pod template
of the cf task job as limits/requests

Issue: #1197

Co-authored-by: Georgi Sabev <[email protected]>
@gcapizzi gcapizzi added this to the v0.2 milestone Jul 14, 2022
@gcapizzi gcapizzi moved this to ✅ Done in Korifi - Backlog Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danail-branekov danail-branekov

@georgethebeatle georgethebeatle

Labels
Tasks
Projects
Korifi - Backlog
Archived in project
Milestone
v0.2
Development

No branches or pull requests
3 participants
@gcapizzi @danail-branekov @georgethebeatle