OS Detection and specs work on non-centos and future CentOS versions #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS detection specs even on CentOS 6 would fail for non RH OSes. OS detection on CentOS 7 would fail completely due to format changes for /etc/redhat-release. OS detection would like have detected incorrectly on >9 as only a single digit was matched by regex.
|
Hey chrisumbel! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. |
|
Redid the pull request as ended up in too funky a state. |
|
Thanks, and sorry for the inverse-squash yesterday:) |
|
No worries. First time is rough for everybody. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-Centos RH OSes (i.e. Fedora which is used on Jenkins) were similarly unable to test because they got trapped out in repository_index.rb. OS detection specs even on CentOS 6 would fail when doing tests for the non-RH OSes.
OS detection on CentOS 7 would fail completely due to format changes for /etc/redhat-release.
OS detection would like have detected incorrectly on >9 as only a single digit was matched by regex.
Integration tests (spec/bin/*) still fail on non-Centos 6, RHEL-based OSes, but all other tests pass now.
Related to #183
trying again