fix(expect-proxy): provide alternative health endpoint for expect_proxy_cidrs #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xy_cidrs `expect_proxy_cidrs` is used for dynamically determining whether proxy protocol should be used or not. On AWS the health check and regular traffic are forwarded with or without proxy protocol. The idea of adding the `expect-proxy` directive CIDRs for AWS load balancer IP addresses as a "marker" for traffic that should become Proxy Protocol, while other traffic (including transparently proxied traffic) remains without Proxy Protocol. By adding a new health endpoint, when `expect_proxy_cidrs` is set, the operator can select, which endpoint to use for checking the health of HAProxy.
peanball
force-pushed
the
expect_proxy_health_endpoint
branch
3 times, most recently
from
06ce19d
to
5b7ffb1
Compare
When `expect_proxy_cidrs` is set, the health check endpoints work as follows: * 8080 (`health_check_port`): the health check endpoint works via regular HTTP * 8081 (`health_check_port` + 1): the alternative health check endpoint works only with Proxy Protocol Operators can then select, which endpoint they want to use in accordance with their `expect_proxy_cidrs` settings.
peanball
force-pushed
the
expect_proxy_health_endpoint
branch
from
5b7ffb1
to
c09d86a
Compare
maxmoehl
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expect_proxy_cidrsis used for dynamically determining whether proxy protocol should be used or not. On AWS the health check and regular traffic are forwarded with or without proxy protocol.The idea of adding the
expect-proxydirective CIDRs for AWS load balancer IP addresses as a "marker" for traffic that should become Proxy Protocol, while other traffic (including transparently proxied traffic) remains without Proxy Protocol.By adding a new health endpoint, when
expect_proxy_cidrsis set, the operator can select, which endpoint to use for checking the health of HAProxy.