fix: docker startup in acceptance #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only trap docker stop after you have started it. Otherwise errors in the loop try to stop it already, while waiting for startup.
mtekel
force-pushed
the
docker-acceptance-fix
branch
from
8ac670b
to
f0386f1
Compare
Increase wait intervals to not spam tests with errors on initial start (1s is usually too slow). Attempt to start service more than once in case it did not come up. Give it more time to start. Improve error message when startup fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set -e, because then we trap service docker stop and docker never starts. Instead keep waiting.