SurgicalPool extension by the load balancing algorithm (the same way as the RoutePool) #460
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding reference to an issue #458 |
peanball
approved these changes
Dec 17, 2024
|
Before you merge a PR, please make sure you run ALL of the tests via This PR broke the tests because of a go fmt issue that would've been caught with the script. Also I am concerned that there were no tests for this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #458
LoadBalancing Algorithm was introduced for the RoutePool in the PR.
The load balancing algorithm is also needed to be passed to the SurgicalPool (included in the RouteOpts for the initialization).
Missing load balancing algorithm in the surgical pool leads to the error "invalid-pool-load-balancing-algorithm".
This error is intended validation for a pool load balancing algorithm. An additional log parameter was added for this error either.
Reproduction Steps
When I curl an app with an x-cf-app-instance header
curl -v "https://example-app.com/" -H "x-cf-app-instance: app_id:instance_id"
The same curl without the instance header works properly.
Backward Compatibility
Breaking Change? No