Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Regenerate CRDs with [email protected] #22

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

Birdrock
Copy link
Member

No description provided.

- CRD status fields are deleted in controller-gen >= v0.9.0
@tcdowney
Copy link
Member

LGTM

Context for this was we need to get rid of the empty status field on the custom resource definitions since they confuse tooling like kapp-controller (it tries to converge back to an empty status state whenever the status is updated).

and TIL about x-kubernetes-map-type:

// x-kubernetes-map-type annotates an object to further describe its topology.
// This extension must only be used when type is object and may have 2 possible values:
//
// 1) `granular`:
//      These maps are actual maps (key-value pairs) and each fields are independent
//      from each other (they can each be manipulated by separate actors). This is
//      the default behaviour for all maps.
// 2) `atomic`: the list is treated as a single entity, like a scalar.
//      Atomic maps will be entirely replaced when updated.
// +optional

@danail-branekov danail-branekov merged commit e25dea1 into master Jul 19, 2022
@danail-branekov danail-branekov deleted the regen-crds-controller-gen-0-9-2 branch July 19, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants