This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Deprecate Env and add Environment field to lrp and task #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2022 16:24
This is a slice of `corev1.EnvVar`s so people can set env vars however k8s supports it. In particular, the secret key ref is supported so that secret values need not be exposed in the spec. This also deprecates the LRP `Env` field. `Environment` supports the plain text env vars that `Env` allows so `Env` can eventually be removed. Issue: cloudfoundry/korifi#917
This reproduces the LRP change on the task resource. It deprecates the `env` field, replacing it with the full functionality enabled by using a slice of corev1.EnvVars Issue: cloudfoundry/korifi#917
danail-branekov
approved these changes
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Env is a map[string]string which is translated to a slice of corev1.EnvVar with values set literally on the statefulset or job.
This potentially exposes secrets, so a better approach is to simply accept a slice of corev1.EnvVar on the LRP or Task resource.
This PR does that on LRP and Task in a new field called
Environment(environmentin the JSON). TheEnvfield is marked as deprecated.