chore: remove run-in-docker logic from Makefile #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187011518 The labels on this github issue will be updated when the story is started. |
blgm
reviewed
Feb 8, 2024
Makefile
Outdated
| ####### broker environment variables | ||
| SECURITY_USER_NAME := $(or $(SECURITY_USER_NAME), aws-broker) | ||
| SECURITY_USER_PASSWORD := $(or $(SECURITY_USER_PASSWORD), aws-broker-pw) | ||
| GSB_PROVISION_DEFAULTS := $(or $(GSB_PROVISION_DEFAULTS), {"aws_vpc_id": "$(AWS_PAS_VPC_ID)"}) | ||
|
|
||
| ifeq ($(GO_OK), 0) # use local go binary | ||
| GO=go |
There was a problem hiding this comment.
Potentially we can inline these variables as they now only have one value
The same benefits can be achieved by simply launching an interactive docker session inside a supported image and running commands from there. This approach has some additional benefits - Easier to maintain - Debloats Makefile - Less hidden magic - Same code for local and containerised execution
blgm
force-pushed
the
chore-fnaranjo-cleanup
branch
from
62b6365 to
b8eacf9
Compare
blgm
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same benefits can be achieved by simply launching an interactive docker session inside a supported image and running commands from there. This approach has some additional benefits
Checklist:
make run-integration-testsandmake run-terraform-tests?