fix: Orphaned encrypted_value records #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a credential was deleted, its related encrypted_value records were not being deleted. - Implemented a trigger to make sure that those records are deleted. [#182121168]
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
swalchemist
reviewed
Mar 7, 2024
...rces/db/migration/mysql/V57_2__delete_related_encrypted_value_when_credential_is_deleted.sql
Outdated
Show resolved
Hide resolved
bruce-ricard
reviewed
Mar 7, 2024
...rces/db/migration/mysql/V57_2__delete_related_encrypted_value_when_credential_is_deleted.sql
Outdated
Show resolved
Hide resolved
bruce-ricard
reviewed
Mar 7, 2024
...rces/db/migration/mysql/V57_2__delete_related_encrypted_value_when_credential_is_deleted.sql
Outdated
Show resolved
Hide resolved
Tallicia
reviewed
Mar 7, 2024
...rces/db/migration/mysql/V57_2__delete_related_encrypted_value_when_credential_is_deleted.sql
Outdated
Show resolved
Hide resolved
bruce-ricard
reviewed
Mar 7, 2024
...src/test/java/org/cloudfoundry/credhub/services/DefaultCredentialVersionDataServiceTest.java
Outdated
Show resolved
Hide resolved
bruce-ricard
reviewed
Mar 7, 2024
...src/test/java/org/cloudfoundry/credhub/services/DefaultCredentialVersionDataServiceTest.java
Show resolved
Hide resolved
hsinn0
force-pushed
the
182121168-del-encrypted_values
branch
2 times, most recently
from
f3a4de3 to
fc35826
Compare
|
Rewrote mysql trigger to use cursor instead of temp table. Also got rid of previous commit with test code change as the added code to the existing test cases had issues giving inconsistent result. Will add new test cases instead. |
- Rewrote the trigger not to use temporary tables. [#182121168]
hsinn0
force-pushed
the
182121168-del-encrypted_values
branch
4 times, most recently
from
e57a34d to
84a2735
Compare
- MySQL trigger to delete associated encrypted_value records when credential_versions are deleted - Implemented triggers on both credential and credential_version table because a credential_version record can be deleted not only when a credential is deleted but also directly. - This will cause h2 & postgresql test cases to fail until triggers are implemented for those databases. [#182121168] Co-authored-by: Bruce Ricard <[email protected]>
hsinn0
force-pushed
the
182121168-del-encrypted_values
branch
from
84a2735 to
7ea712c
Compare
- Added PostgreSQL trigger to delete associated encrypted_value records when credential_versions are deleted. [#182121168]
hsinn0
force-pushed
the
182121168-del-encrypted_values
branch
from
0788cb4 to
82cef8d
Compare
hsinn0
changed the title
* Do not assert on the count of the "encrypted_value" table when using the H2 in-memory test database. Co-Authored-by: Bruce Ricard <[email protected]> [#182121168](https://www.pivotaltracker.com/story/show/182121168)
* To help debug by logging whether the assertion runs or not Co-Authored-by: Bruce Ricard <[email protected]> [#182121168](https://www.pivotaltracker.com/story/show/182121168)
Co-Authored-by: Bruce Ricard <[email protected]>
|
This PR attempts to resolve #231 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#182121168]
There will be more commits, including tests, triggers for other databases and indexes to address delete operation performance.