Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deletion of old credential versions not possible #190

Open
3 tasks
dueckminor opened this issue May 7, 2021 · 4 comments
Open
3 tasks

deletion of old credential versions not possible #190

dueckminor opened this issue May 7, 2021 · 4 comments

Comments

@dueckminor
Copy link

What version of the credhub server you are using?
2.9.0

What version of the credhub cli you are using?
2.9.0

If you were attempting to accomplish a task, what was it you were attempting to do?
I rotate/update (non-certificate) credentials regularly using the credhub cli by either using:

  • credhub set
  • credhub generate
  • credhub regenerate

What did you expect to happen?
I would expect that this doesn't decrease the overall CredHub performance and that the CredHub CLI/API would allow me to delete old versions of the credential. For certificate credentials, there is such an API, but not for all other types of credentials.

What was the actual behaviour?
All currently available method to update a credential will lead to an addition version of the same credential. There is currently no API available which allows to remove old and obsolete versions of one credential.
If the number of versions grows (more than 5000), the performance of CredHub dramatically decreases and CredHub finally gets unhealthy (I observed a high CPU load on the Database)

Please confirm where necessary:

  • I have included a log output
  • My log includes an error message
  • I have included steps for reproduction

If you are a PCF customer with an Operation Manager (PCF Ops Manager) please direct your questions to support (https://support.pivotal.io/)

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/178068836

The labels on this github issue will be updated when the story is started.

@swalchemist
Copy link
Contributor

#231 seems similar.

@bruce-ricard
Copy link
Contributor

I guess deleting the credential and recreating it could be a workaround. If you want to cleanup all old versions of a credential, you can run credhub delete --name ... and then credhub generate or set again. All older versions will be gone.

But I agree that this is a pretty valid feature request.

@bruce-ricard
Copy link
Contributor

Sorry about the wrong link just above. The PR fixes another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants